Fix find_link_library in the event the linker flag check fails. #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WildCard65 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the find_link_library CMake function where the library name parameter was not being properly passed to find_library, and improves variable naming to avoid potential conflicts across multiple invocations.
- Corrects the
find_librarycall to actually use thelibnameparameter instead of treating it as a literal string - Updates variable names to be unique per library to prevent potential CMake variable collision issues
|
@microsoft-github-policy-service agree |
|
Hi @WildCard65 , thanks for the fix, but can you make this PR against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small pull request fixes the issue #1113 by doing 2 things: